Deploy RDMA CNI as a part of SR-IOV Operator #661

e0ne · 2024-03-19T08:23:19Z

No description provided.

github-actions · 2024-03-19T08:23:32Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-03-19T08:29:24Z

Pull Request Test Coverage Report for Build 9858421191

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 40.952%

Files with Coverage Reduction	New Missed Lines	%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9774956990:	-0.03%
Covered Lines:	5585
Relevant Lines:	13638

💛 - Coveralls

github-actions · 2024-03-19T11:50:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

hack/env.sh

github-actions · 2024-03-25T19:48:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov

LGTM

bindata/manifests/daemon/daemonset.yaml

github-actions · 2024-03-26T14:32:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

LGTM

github-actions · 2024-04-03T13:26:02Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-03T13:28:47Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-03T13:59:28Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne · 2024-04-15T07:02:30Z

@SchSeba could you please review this PR?

SchSeba

sorry for the super late review.

I add some small comments

SchSeba · 2024-04-24T10:52:37Z

bindata/manifests/daemon/daemonset.yaml

@@ -92,6 +92,23 @@ spec:
              mountPath: /host/etc/os-release
              readOnly: true
        {{- end }}
+        {{- if ne .RDMACNIImage "" }}


nit: please can the if statement be the same as {{- if .OVSCNIImage }}

SchSeba · 2024-04-24T10:54:32Z

bindata/manifests/daemon/daemonset.yaml

+        - name: rdma-cni
+          image: {{.RDMACNIImage}}
+          command:
+            - /bin/sh


please let's not have a copy like this here.

can we create an entrypoint.sh and use it in the image for the rdma-cni repo (I can review and approve it)

the same way we do for the sriov-cni

PR to SR-IOV CNI: k8snetworkplumbingwg/rdma-cni#56

SchSeba · 2024-04-24T10:58:00Z

hack/env.sh

@@ -13,6 +15,8 @@ else
        [ -z $SRIOV_INFINIBAND_CNI_IMAGE ] && echo "SRIOV_INFINIBAND_CNI_IMAGE is empty but SKIP_VAR_SET is set" && exit 1
        # check that OVS_CNI_IMAGE is set to any value, empty string is a valid value
        [ -z ${OVS_CNI_IMAGE+set} ] && echo "OVS_CNI_IMAGE is empty but SKIP_VAR_SET is set" && exit 1
+        # check that RDMA_CNI_IMAGE is set to any value, empty string is a valid value
+        [ -z ${$RDMA_CNI_IMAGE+set} ] && echo "RDMA_CNI_IMAGE is empty but SKIP_VAR_SET is set" && exit 1


please do something like we did for the ovs-cni

# ensure that OVS_CNI_IMAGE is set, empty string is a valid value OVS_CNI_IMAGE=${OVS_CNI_IMAGE:-}

github-actions · 2024-04-25T12:00:16Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-25T12:10:32Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

just two small comments and we should be good to go nice work

SchSeba · 2024-05-02T03:46:12Z

hack/env.sh

@@ -11,6 +13,8 @@ if [ -z $SKIP_VAR_SET ]; then
 else
        # ensure that OVS_CNI_IMAGE is set, empty string is a valid value
        OVS_CNI_IMAGE=${OVS_CNI_IMAGE:-}
+        # ensure that RDMA_CNI_IMAGE is set, empty string is a valid value
+        $RDMA_CNI_IMAGE=${$RDMA_CNI_IMAGE:-}


$RDMA_CNI_IMAGE= -> RDMA_CNI_IMAGE=

bindata/manifests/daemon/daemonset.yaml

SchSeba

LGTM

/hold

please lets wait for #700 and release cut before we merge this

adrianchiris · 2024-06-25T09:14:23Z

@e0ne please rebase so we can give it a final review and merge.

github-actions · 2024-06-25T09:23:24Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne · 2024-06-25T09:23:29Z

@e0ne please rebase so we can give it a final review and merge.

done

rollandf · 2024-06-25T09:30:19Z

hack/env.sh

@@ -3,6 +3,8 @@ if [ -z $SKIP_VAR_SET ]; then
        export SRIOV_INFINIBAND_CNI_IMAGE=${SRIOV_INFINIBAND_CNI_IMAGE:-ghcr.io/k8snetworkplumbingwg/ib-sriov-cni}
        # OVS_CNI_IMAGE can be explicitly set to empty value, use default only if the var is not set
        export OVS_CNI_IMAGE=${OVS_CNI_IMAGE-ghcr.io/k8snetworkplumbingwg/ovs-cni-plugin}
+        # RDMA_CNI_IMAGE can be explicitly set to empty value, use default only if the var is not set
+                export RDMA_CNI_IMAGE=${RDMA_CNI_IMAGE-ghcr.io/k8snetworkplumbingwg/rdma-cni}


Please align indentation.

rollandf · 2024-06-25T09:30:26Z

hack/env.sh

@@ -13,6 +15,8 @@ if [ -z $SKIP_VAR_SET ]; then
 else
        # ensure that OVS_CNI_IMAGE is set, empty string is a valid value
        OVS_CNI_IMAGE=${OVS_CNI_IMAGE:-}
+        # ensure that RDMA_CNI_IMAGE is set, empty string is a valid value
+                RDMA_CNI_IMAGE=${$RDMA_CNI_IMAGE:-}


Please align indentation.

github-actions · 2024-06-25T09:33:06Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

LGTM, please align indent as @rollandf commented and we can merge.

github-actions · 2024-07-02T20:54:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

@e0ne can you rebase against master ?

adrianchiris · 2024-07-08T07:33:48Z

deployment/sriov-network-operator-chart/values.yaml

@@ -103,6 +103,7 @@ images:
  sriovCni: ghcr.io/k8snetworkplumbingwg/sriov-cni
  ibSriovCni: ghcr.io/k8snetworkplumbingwg/ib-sriov-cni
  ovsCni: ghcr.io/k8snetworkplumbingwg/ovs-cni-plugin
+  rdmaCni: ghcr.io/k8snetworkplumbingwg/rdma-cni


please update helm chart update script :

sriov-network-operator/hack/release/chart-update.sh

Line 47 in 2fed72e

OVS_CNI_TAG=$(get_latest_github_tag k8snetworkplumbingwg ovs-cni)

@adrianchiris done

github-actions · 2024-07-08T11:26:36Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

LGTM

nice work!

SchSeba · 2024-07-08T15:27:55Z

/hold

Hi @e0ne please check the k8s CI looks like the helm deploy doesn't work

SchSeba · 2024-07-08T15:50:11Z

please add the image here

https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/hack/run-e2e-conformance-virtual-cluster.sh#L387

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>

github-actions · 2024-07-09T13:56:16Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne · 2024-07-09T14:01:06Z

/hold

Hi @e0ne please check the k8s CI looks like the helm deploy doesn't work

fixed a typo

e0ne · 2024-07-09T14:01:19Z

please add the image here

https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/hack/run-e2e-conformance-virtual-cluster.sh#L387

why do we need to to it?

SchSeba · 2024-07-09T14:12:04Z

/hold cancel

SchSeba · 2024-07-11T13:59:25Z

Hi @adrianchiris can you please approve so we can merge this one?

e0ne force-pushed the rdma-cni branch from db0924f to bbdfd9d Compare March 19, 2024 11:50

e0ne marked this pull request as ready for review March 19, 2024 11:50

ykulazhenkov reviewed Mar 19, 2024

View reviewed changes

hack/env.sh Outdated Show resolved Hide resolved

ykulazhenkov reviewed Mar 19, 2024

View reviewed changes

hack/env.sh Outdated Show resolved Hide resolved

e0ne force-pushed the rdma-cni branch from bbdfd9d to 225a839 Compare March 25, 2024 19:48

ykulazhenkov approved these changes Mar 26, 2024

View reviewed changes

zeeke reviewed Mar 26, 2024

View reviewed changes

bindata/manifests/daemon/daemonset.yaml Outdated Show resolved Hide resolved

e0ne force-pushed the rdma-cni branch from 225a839 to af30c8a Compare March 26, 2024 14:32

zeeke approved these changes Mar 26, 2024

View reviewed changes

e0ne requested a review from SchSeba April 2, 2024 14:33

e0ne force-pushed the rdma-cni branch from af30c8a to 7b83dba Compare April 3, 2024 13:22

e0ne closed this Apr 3, 2024

e0ne reopened this Apr 3, 2024

e0ne force-pushed the rdma-cni branch from 7b83dba to d5f82c5 Compare April 3, 2024 13:59

SchSeba reviewed Apr 24, 2024

View reviewed changes

e0ne force-pushed the rdma-cni branch from d5f82c5 to 207961f Compare April 25, 2024 12:00

e0ne force-pushed the rdma-cni branch from 207961f to e4b3a56 Compare April 25, 2024 12:10

SchSeba reviewed May 2, 2024

View reviewed changes

e0ne force-pushed the rdma-cni branch from e4b3a56 to c9ad2c7 Compare May 3, 2024 17:21

SchSeba approved these changes May 27, 2024

View reviewed changes

e0ne force-pushed the rdma-cni branch from c9ad2c7 to 0fe0709 Compare June 25, 2024 09:23

rollandf reviewed Jun 25, 2024

View reviewed changes

e0ne force-pushed the rdma-cni branch from 0fe0709 to 407709c Compare June 25, 2024 09:32

adrianchiris reviewed Jun 25, 2024

View reviewed changes

adrianchiris approved these changes Jun 25, 2024

View reviewed changes

e0ne force-pushed the rdma-cni branch from 407709c to 038853b Compare July 2, 2024 20:54

adrianchiris reviewed Jul 8, 2024

View reviewed changes

adrianchiris self-requested a review July 8, 2024 07:34

e0ne force-pushed the rdma-cni branch from 038853b to 115e188 Compare July 8, 2024 11:26

SchSeba approved these changes Jul 8, 2024

View reviewed changes

github-actions bot added the hold label Jul 8, 2024

Deploy RDMA CNI as a part of SR-IOV Operator

f439d47

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>

e0ne force-pushed the rdma-cni branch from 115e188 to f439d47 Compare July 9, 2024 13:56

github-actions bot removed the hold label Jul 9, 2024

adrianchiris approved these changes Jul 11, 2024

View reviewed changes

adrianchiris merged commit c3ba0f3 into k8snetworkplumbingwg:master Jul 11, 2024
13 checks passed

Deploy RDMA CNI as a part of SR-IOV Operator #661

Deploy RDMA CNI as a part of SR-IOV Operator #661

Conversation

e0ne commented Mar 19, 2024

github-actions bot commented Mar 19, 2024

coveralls commented Mar 19, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9858421191

Details

💛 - Coveralls

github-actions bot commented Mar 19, 2024

github-actions bot commented Mar 25, 2024

ykulazhenkov left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 26, 2024

zeeke left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 3, 2024

github-actions bot commented Apr 3, 2024

e0ne commented Apr 15, 2024

SchSeba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

SchSeba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SchSeba left a comment

Choose a reason for hiding this comment

adrianchiris commented Jun 25, 2024

github-actions bot commented Jun 25, 2024

e0ne commented Jun 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 25, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 8, 2024

SchSeba left a comment

Choose a reason for hiding this comment

SchSeba commented Jul 8, 2024

SchSeba commented Jul 8, 2024

github-actions bot commented Jul 9, 2024

e0ne commented Jul 9, 2024

e0ne commented Jul 9, 2024

SchSeba commented Jul 9, 2024

SchSeba commented Jul 11, 2024

coveralls commented Mar 19, 2024 •

edited

Loading